Skip to content

Fix table view crashes with missing responses or name/$autoname #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2019
Merged

Fix table view crashes with missing responses or name/$autoname #2195

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
317bf3a
safety check if $autoname exists
magicznyleszek Feb 12, 2019
dfb853e
check name and $autoname
magicznyleszek Feb 12, 2019
66a5bf2
Fix crash in table view with missing responses
jnm Feb 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions jsapp/js/components/table.es6
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,11 @@ export class DataTable extends React.Component {

const surveyKeys = [];
this.props.asset.content.survey.forEach((row) => {
surveyKeys.push(row.$autoname);
if (row.name) {
surveyKeys.push(row.name);
} else if (row.$autoname) {
surveyKeys.push(row.$autoname);
}
});

// make sure the survey columns are displayed, even if current data's
Expand Down Expand Up @@ -413,7 +417,11 @@ export class DataTable extends React.Component {
return formatTimeDate(row.value);
}
}
return typeof(row.value) == 'object' ? '' : row.value;
if (typeof(row.value) == 'object' || row.value === undefined) {
return '';
} else {
return row.value;
}
}
});

Expand Down Expand Up @@ -763,6 +771,8 @@ export class DataTable extends React.Component {
selectAll = this.state.selectAll;
var d = null;

// TODO bulk change to no status

if (!selectAll) {
d = {
submissions_ids: Object.keys(this.state.selectedRows),
Expand Down