Branch to be used with kpi.REST-UI
#482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss' boolean field to 'Instance' model
…ParsedInstance.save()
… to be consistent with the kpi code
…ield, added command to update is_synced_with_mongo according to Mongo records
… for inactive XForm
jnm
reviewed
Sep 25, 2018
Member
|
I left the one comment for possible performance improvement, but I wouldn't block the merge as-is. @noliveleger, you'll probably get around to tweaking it before I finish reviewing the KPI branch ;) |
jnm
requested changes
Sep 25, 2018
| offset = 0 | ||
| while stop is not True: | ||
| limit = offset + batchsize | ||
| instances_ids = Instance.objects.values_list("id", flat=True)[offset:limit] |
Member
There was a problem hiding this comment.
Ah, I forgot about this—adding it as a requested change. I think the queryset should be ordered explicitly by pk (or id) when using this kind of chunking. Otherwise, I think the order of values returned will be undefined.
jnm
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can submit data to
kpito letkpitransfer it to remote servers