Skip to content

remove unused test suite #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
legrego wants to merge 2 commits into from
Closed

remove unused test suite #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ded1f7
remove unused test suite
legrego Nov 15, 2018
6a55b8d
attempt to fix karma tests
legrego Nov 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/core_plugins/tests_bundle/tests_entry_template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ new CoreSystem({
enableExternalUrls: true
},
uiCapabilities: {
navLinks: {
myLink: true,
notMyLink: true,
},
discover: {
showWriteControls: true
},
Expand Down
12 changes: 9 additions & 3 deletions src/ui/public/chrome/directives/global_nav/app_switcher/__tests__/app_switcher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,15 @@ describe('appSwitcher directive', function () {
const myLink = {
active: true,
title: 'myLink',
id: 'myLink',
url: 'http://localhost:555/app/myApp',
lastSubUrl: 'http://localhost:555/app/myApp#/lastSubUrl'
};

const notMyLink = {
active: false,
title: 'notMyLink',
id: 'notMyLink',
url: 'http://localhost:555/app/notMyApp',
lastSubUrl: 'http://localhost:555/app/notMyApp#/lastSubUrl'
};
Expand All @@ -95,13 +97,15 @@ describe('appSwitcher directive', function () {
const myLink = {
active: false,
title: 'myLink',
id: 'myLink',
url: 'http://localhost:555/app/myApp',
lastSubUrl: 'http://localhost:555/app/myApp#/lastSubUrl'
};

const notMyLink = {
active: false,
title: 'notMyLink',
id: 'notMyLink',
url: 'http://localhost:555/app/notMyApp',
lastSubUrl: 'http://localhost:555/app/notMyApp#/lastSubUrl'
};
Expand All @@ -124,7 +128,7 @@ describe('appSwitcher directive', function () {
describe('clicking a link with matching href but missing hash', function () {
const url = 'http://localhost:555/app/myApp?query=1';
beforeEach(setup(url + '#/lastSubUrl', [
{ url: url }
{ url: url, id: 'myLink' }
]));

it('just prevents propagation (no reload)', function () {
Expand All @@ -147,7 +151,7 @@ describe('appSwitcher directive', function () {
describe('clicking a link that matches entire url', function () {
const url = 'http://localhost:555/app/myApp#/lastSubUrl';
beforeEach(setup(url, [
{ url: url }
{ url: url, id: 'myLink' }
]));

it('calls window.location.reload and prevents propagation', function () {
Expand All @@ -172,7 +176,7 @@ describe('appSwitcher directive', function () {
const url = rootUrl + '#/lastSubUrl2';

beforeEach(setup(url + '#/lastSubUrl', [
{ url: url }
{ url: url, id: 'myLink' }
]));

it('calls window.location.reload and prevents propagation', function () {
Expand All @@ -195,6 +199,7 @@ describe('appSwitcher directive', function () {
describe('clicking a link with matching host', function () {
beforeEach(setup('http://localhost:555/someOtherPath', [
{
id: 'myLink',
active: true,
url: 'http://localhost:555/app/myApp'
}
Expand All @@ -216,6 +221,7 @@ describe('appSwitcher directive', function () {
describe('clicking a link with matching host and path', function () {
beforeEach(setup('http://localhost:555/app/myApp?someQuery=true', [
{
id: 'myLink',
active: true,
url: 'http://localhost:555/app/myApp?differentQuery=true'
}
Expand Down
10 changes: 0 additions & 10 deletions x-pack/plugins/spaces/server/lib/toggle_ui_capabilities.test.ts
View file
Open in desktop

This file was deleted.