Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a hydration error in SSR apps #76

Merged
merged 1 commit into from
Jul 12, 2022
Merged

fix: a hydration error in SSR apps #76

merged 1 commit into from
Jul 12, 2022

Conversation

koba04
Copy link
Owner

@koba04 koba04 commented Jul 12, 2022

Currently, SWRDevTools causes a hydration error with SSR apps because it inserts a script element in the application.
This PR has changed the way to inspect SWRDevTools middleware in to the application. I've used scripting.executeScript instead of adding a script element.

In order to use the API, I've added some permissions.

Before
Screen Shot 2022-07-12 at 23 54 32

After
Screen Shot 2022-07-12 at 23 53 01

@vercel
Copy link

vercel bot commented Jul 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
swr-devtools ✅ Ready (Inspect) Visit Preview Jul 12, 2022 at 3:04PM (UTC)

@koba04 koba04 merged commit c30626f into main Jul 12, 2022
@koba04 koba04 deleted the fix-hydration-error branch July 12, 2022 15:45
@koba04
Copy link
Owner Author

koba04 commented Jul 12, 2022

This didn't fix the issue, so I'll investigate it again.

koba04 added a commit that referenced this pull request Jul 13, 2022
koba04 added a commit that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants