-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network tab #51
Merged
Network tab #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I'll fix the lint error as well as dark mode support :) |
koba04
approved these changes
Jun 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, great works!!! 👏 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28.
This PR adds an initial implementation of a Network tab (waterfall chart) similar to Chrome DevTools' Network Tab. Basic design behind this:
window.postMessage
to the extension window.SWRDevToolPanel
receives the events and gives them toNetworkPanel
.NetworkPanel
cleans up the data, grouping them by hook keys, and give it to the timeline scroller.timeline/index.tsx
is a headless virtual timeline scroller and handles the UI.I tested the virtual scroller with 500
useSWR
hooks and 1000+ requests and it's still pretty smooth on my laptop. Also, I added some random delay to the API and enabled the failing hook.I noticed a couple of bugs, such as
ongoing
request that never ends, but should be good at the moment. Another thing to be done is supportinguseSWRInfinite
.