feat: set name of middleware function to improve interop with monitoring tools #159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set name of middleware function to improve interop with monitoring tools.
Tools like @opentelemetry/instrumentation-koa use function names to generate span names. These names appear in UI of monitoring tools, such as datadog.
Because the returned function doesn't have a name, there's no hint about the actual middleware associated with that span. See below:
In v4 the returned middleware had a name but in v5 got removed, see:
bodyparser/index.js
Line 63 in 5678a79
Checklist