-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go1.18: Preserve trailing tabs while massaging go version -m
output
#668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add this to massageBuildInfo?
Ooh, I didn't notice |
Oh no. 😭 |
go version -m
output
Thanks again for the This PR has been updated to address the root cause instead of putting lipstick on a pig. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉🎉🎉
Codecov Report
@@ Coverage Diff @@
## main #668 +/- ##
=======================================
Coverage 51.62% 51.62%
=======================================
Files 44 44
Lines 3268 3268
=======================================
Hits 1687 1687
Misses 1371 1371
Partials 210 210 Continue to review full report at Codecov.
|
Allows ko on both go v1.17 and v1.18 to parse
go version -m
output that contains a local replace directive. For example:./main: go1.18 path command-line-arguments dep secret.dev/api v0.0.0-00010101000000-000000000000 => ../api (devel)
The issue is that
ParseBuildInfo
assumes there is a 3rd column that contains a checksum, which is not applicable to local replace directives. This patch inserts the extra tab, allowing it to have an empty checksum.Fixes #666