Fix issues related to Go 1.18 #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #657 +/- ##
=======================================
Coverage 51.62% 51.62%
=======================================
Files 44 44
Lines 3268 3268
=======================================
Hits 1687 1687
Misses 1371 1371
Partials 210 210 Continue to review full report at Codecov.
|
Update our internal fork for 1.18's ParseBuildInfo for use by pre-1.18 build versions to exactly the code used in the Go 1.18 release branch. This affects users who `go install` ko running Go <1.18, since that code was old and incompatible with 1.18-produced output of `go version -m`. Add a workflow to test all combinations of pre- and post-1.18 setups for both how ko was built, and what version of Go is installed by the user. Update our release workflow to build using Go 1.18, so users who download built binaries don't depend on our forked code at all.
mattmoor
approved these changes
Mar 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update our internal fork for 1.18's ParseBuildInfo for use by pre-1.18 build versions to exactly the code used in the Go 1.18 release branch.
This affects users who
go installko running Go <1.18, since that code was old and incompatible with 1.18-produced output ofgo version -m. This also affects users running released binaries, since those were built with 1.17 in our release process.Add a workflow to test all combinations of pre- and post-1.18 setups for both how ko was built, and what version of Go is installed by the user.
Update our release workflow to build using Go 1.18, so users who download built binaries don't depend on our forked code at all.
Ref #651
Fixes #650