use automaxprocs to calculate the number of CPUs

[dprotaso]

this is useful for container environments

Addresses: #642

[dprotaso]

misspell doesn't ignore vendor

[imjasonh]

Can you share how you verified that this helps? I'd like to understand it better.

Something like this?

docker run --cpus=1 -v $(pwd):/workspace --workdir=/workspace $(ko build ./ --local) resolve -f ./test/

That only matches one importpath, but I guess I could run it against Knative or Tekton or Triggermesh to see it correctly limit parallelism.

[dprotaso]

Related issue: golang/go#33803

[dprotaso]

Essentially GOMAXPROCS is not cgroup aware so it reports the total CPUs on the machine instead of the # of CPUs allocated to the container

[dprotaso]

Also I don't claim this fixes the issue but is a big part. I think in earlier versions of ko something else was limiting parallelism (besides the limiter). Hence why we never encountered this issue

[dprotaso]

the other notable thing is cgroupsv2 support isn't in the library yet

• Support cgroup2 uber-go/automaxprocs#44

[dprotaso]

got the typo fixed upstream - force pushing the fix

[imjasonh]

This seems worth doing, and unlikely to cause any new problems. After this is merged I'll try it out and see if it changes the behavior.

Thanks for this fix!

[akshayjshah]

Keep in mind that automaxprocs doesn't (yet) support cgroups v2 :)