-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for --image-refs
#555
Conversation
Pretty sure I need to update the CLI docs, so this will fail. |
Ok, pushed an update with the codegen |
Codecov Report
@@ Coverage Diff @@
## main #555 +/- ##
==========================================
- Coverage 48.82% 48.58% -0.24%
==========================================
Files 42 43 +1
Lines 2204 2229 +25
==========================================
+ Hits 1076 1083 +7
- Misses 946 959 +13
- Partials 182 187 +5
Continue to review full report at Codecov.
|
This change adds a new `--image-refs=FILE` flag that can be used to direct `ko` to write a file containing a `\n` delimited list of published references. In the common case, this will contain the list of digest references, but if flags directing the use of tags are present this will reflect the style of reference requested.
Fixed the couple little things, good eyes. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but I'd like Jon to weigh in before merging.
This change adds a new
--image-refs=FILE
flag that can be used todirect
ko
to write a file containing a\n
delimited list of publishedreferences. In the common case, this will contain the list of digest
references, but if flags directing the use of tags are present this
will reflect the style of reference requested.