-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support osversion when selecting base images #536
Conversation
Codecov Report
@@ Coverage Diff @@
## main #536 +/- ##
==========================================
- Coverage 48.16% 48.12% -0.05%
==========================================
Files 42 42
Lines 2182 2184 +2
==========================================
Hits 1051 1051
- Misses 954 955 +1
- Partials 177 178 +1
Continue to review full report at Codecov.
|
Experimenting with the platform syntax used in https://github.com/estesp/mquery where platform is This works:
This currently panicks:
I'll work on figuring that out while we decide if we like this syntax. If we go with this format we should probably also get |
Hey, good news, this isn't a new panic introduced by this PR 😅 #544 |
Use this in e2e tests. Also clean up usage of bo.Platform vs a new platform var.
Any more concerns with this? |
Fixes #534
This builds on #533 to add an option to the
--platform
flag to explicitly select a platform by osversion, which happens to be necessary to select the correctgolang:1.17
base image for the GitHub Actions runner environment.