Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default completion command provided by cobra. #522

Merged

Conversation

darklore
Copy link
Contributor

@darklore darklore commented Dec 5, 2021

cobra provides default completion subcommand.
It supports bash, zsh, fish, and powershell by default.

`cobra` provides default `completion` subcommand.
It supports bash, zsh, fish, and powershell by default.
@google-cla google-cla bot added the cla: no label Dec 5, 2021
imjasonh
imjasonh previously approved these changes Dec 5, 2021
Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this!

@imjasonh
Copy link
Member

imjasonh commented Dec 5, 2021

In addition to the CLA, I think you'll also have to regenerate the docs, ./hack/update-codegen.sh

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2021

Codecov Report

Merging #522 (f4363ff) into main (5640c33) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #522      +/-   ##
==========================================
- Coverage   50.60%   50.58%   -0.03%     
==========================================
  Files          41       40       -1     
  Lines        2051     2040      -11     
==========================================
- Hits         1038     1032       -6     
+ Misses        838      834       -4     
+ Partials      175      174       -1     
Impacted Files Coverage Δ
pkg/commands/commands.go 72.72% <ø> (-2.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5640c33...f4363ff. Read the comment docs.

@darklore
Copy link
Contributor Author

darklore commented Dec 5, 2021

Thank you for review.
I updated docs by ./hack/update-cocegen.sh

@imjasonh imjasonh merged commit 6ff3469 into ko-build:main Dec 5, 2021
@darklore darklore deleted the darklore/use-cobra-builtin-completion branch December 5, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants