Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding #ifndef blocks around commonly modified values #124

Conversation

anonymouse64
Copy link

PubSubClient.h : adding #ifndef blocks around the commonly modified #defines to allow the values to be overridden by -D options when compiling. This allows the values to changed without modifying the library source files.

…defines to allow these values to be overridden without changing the source code through -D options when compiling.

Signed-off-by: Ian Johnson <[email protected]>
@knolleary
Copy link
Owner

Hi, thanks for the contribution. There is already an identical pullrequest from a couple days ago waiting for me to deal with. So, going to close your one but not because we don't want to do this change, just that #119 got there first.

@knolleary knolleary closed this Jan 30, 2016
@anonymouse64
Copy link
Author

Ah I didn't even see that one...
Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants