Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop: no further intersect after non-convex #4

Closed
kninnug opened this issue Jan 3, 2022 · 0 comments
Closed

Infinite loop: no further intersect after non-convex #4

kninnug opened this issue Jan 3, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@kninnug
Copy link
Owner

kninnug commented Jan 3, 2022

When trying to constrain the following:

{
    "points": [
        [544, 480],
        [512, 192],
        [544, 160],
        [512, 384],
        [512, 224],
        [544, 320],
        [704, 128],
        [576, 352],
        [672, 352],
        [576, 128],
        [608, 384],
        [672, 96],
        [640, 96],
        [608, 160],
        [672, 160],
        [608, 288]
    ],
    "edges": [
        [1, 2],
        [4, 5],
        [5, 0],
        [6, 8],
        [8, 7],
        [7, 9]
    ]
}

constrainOne(7, 9) fails with Infinite loop: no further intersect after non-convex, which looks like:

issue3

This is because the Delaunay condition needs to be restored after each call to constrainOne, rather than at the end.

@kninnug kninnug added the bug Something isn't working label Jan 3, 2022
@kninnug kninnug self-assigned this Jan 3, 2022
kninnug added a commit that referenced this issue Jan 5, 2022
…Use BitSets instead of flips array. Change return values of constrainAll and delaunify. Add edges parameter to constructor. Add findEdge method. Remove full parameter from delaunify. Add testpack.sh script. Add /min export and minified ESM
@kninnug kninnug closed this as completed Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant