fix DrawRangeElementsBaseVertex (#2187)

* fix DrawRangeElementsBaseVertex * fix DrawRangeElements
kniEngine · Jan 13, 2025 · 69523a0 · 69523a0
1 parent 47269b5
commit 69523a0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/Platforms/Graphics/.GL/ConcreteGraphicsCapabilities.cs b/Platforms/Graphics/.GL/ConcreteGraphicsCapabilities.cs
@@ -29,6 +29,9 @@ internal sealed class ConcreteGraphicsCapabilities : GraphicsCapabilities
         /// </summary>
         internal bool SupportsFramebufferObjectIMG { get; private set; }
 
+        internal bool SupportsBaseVertex { get; private set; }
+        internal bool SupportsDrawRangeElements { get; private set; }
+
         private int _maxDrawBuffers;
 
         internal int MaxDrawBuffers { get { return _maxDrawBuffers; } }
@@ -163,6 +166,10 @@ internal void PlatformInitialize(ConcreteGraphicsContextGL cgraphicsContext, Gra
             SupportsSeparateBlendStates = version >= new GLVersion(4,0) || GL.Extensions.Contains("GL_ARB_draw_buffers_blend");
 #endif
 
+            SupportsBaseVertex = version >= new GLVersion(3,2) || GL.Extensions.Contains("GL_ARB_framebuffer_object");
+            SupportsDrawRangeElements = (GL.BoundApi == OGL.RenderApi.GL && version >= new GLVersion(2, 0))
+                                     || (GL.BoundApi == OGL.RenderApi.ES && version >= new GLVersion(3, 0));
+
             GL.GetInteger(GetParamName.MaxDrawBuffers, out _maxDrawBuffers);
             GL.CheckGLError();
         }

diff --git a/Platforms/Graphics/.GL/ConcreteGraphicsContext.cs b/Platforms/Graphics/.GL/ConcreteGraphicsContext.cs
@@ -877,7 +877,7 @@ public override void DrawIndexedPrimitives(PrimitiveType primitiveType, int base
             int indexElementCount = GraphicsContextStrategy.GetElementCountArray(primitiveType, primitiveCount);
             GLPrimitiveType target = ConcreteGraphicsContext.PrimitiveTypeGL(primitiveType);
 
-            if (baseVertex > 0 && GL.DrawRangeElementsBaseVertex != null)
+            if (baseVertex > 0 && ((ConcreteGraphicsCapabilities)this.Capabilities).SupportsBaseVertex)
             {
                 PlatformApplyVertexBuffers(0);
 
@@ -890,7 +890,7 @@ public override void DrawIndexedPrimitives(PrimitiveType primitiveType, int base
                                   baseVertex);
                 GL.CheckGLError();
             }
-            else if (GL.DrawRangeElements != null)
+            else if (((ConcreteGraphicsCapabilities)this.Capabilities).SupportsDrawRangeElements)
             {
                 PlatformApplyVertexBuffers(baseVertex);