Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.html to match SVG changes #135

Closed
wants to merge 1 commit into from
Closed

Conversation

AdamPS
Copy link
Contributor

@AdamPS AdamPS commented Jul 26, 2015

For issue #130

@AdamPS
Copy link
Contributor Author

AdamPS commented Jul 26, 2015

Sorry I'm just learning git. OK, so it seems this pull request now has my second fix in it automatically. The second one is for #133 and is more complex, I feel potentially very useful, but possibly controversial / wrong:-) So please review carefully before merging.

@dbox
Copy link
Contributor

dbox commented Jul 28, 2015

I'm happy to take the index as a PR but the other one really messes with the icon and font sizing..

@AdamPS
Copy link
Contributor Author

AdamPS commented Jul 28, 2015

True, sorry about that. If I can tweak the numbers and get it a closer in appearance to before, would you be interested? It does solve a bug or two as well as being more compact CSS.

Or is this perhaps the point where I should fork? I'm trying to delay that as I feel the more code we have in common the better for long term ease of maintenance. But I'm not going to bang my head against a brick wall about it.

@dbox
Copy link
Contributor

dbox commented Jul 29, 2015

Yeah, happy to look at it again if you can get it looking exactly 1-to-1, but for now this is very far off.

@dbox
Copy link
Contributor

dbox commented Jul 29, 2015

If you can remove the last commit, I'll get the index merged up at least.

@AdamPS
Copy link
Contributor Author

AdamPS commented Jul 29, 2015

OK, I have reverted the last commit, thanks.

@dbox
Copy link
Contributor

dbox commented Jul 29, 2015

Can you just prune those last 2 commits off? Or I can just bring in the index on its own not in a PR. Thanks!

@AdamPS
Copy link
Contributor Author

AdamPS commented Jul 29, 2015

OK, this is stretching my ability with Git, but I think I might have got it.

@dbox dbox closed this Oct 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants