Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset draining after we are drained #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nullstyle
Copy link

No description provided.

@elliotf
Copy link

elliotf commented Nov 21, 2014

This doesn't seem to address the problem of bookshelf/knex having issues with disconnected DB connections. This change seems to only impact the caller when .drain() is called. Without this change, you need to create a new generic pool (which knex does) .. With this change, you could reuse a pool.

Is that what you were trying to achieve, @nullstyle ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants