General spec cleanup #107
General spec cleanup #107
Conversation
|
Hmm… I just searched the entire repo and Also, I've decided I'm going to rebase and squash to 1 commit. There's really not that much changed here. |
JohnAlbin
force-pushed
the
general-spec-cleanup
branch
from
5c5493c
to
b6652c4
Compare
| @@ -23,7 +23,7 @@ Styleguide 2.1.3. | |||
| a.button.star{ | |||
| ... | |||
| } | |||
| a.button.star.stars-given{ | |||
| a.button.star.star-given{ | |||
There was a problem hiding this comment.
.star-given is what is used in part of the SPEC and everywhere in the test/ directory. Going to assume .stars-given is a typo.
|
This is good to go now. I've added comments to most of the line changes on the files tab: https://github.com/kneath/kss/pull/107/files |
|
Naturally, there would be a ton of merge conflicts if I pushed all the changes from #106 into your PR queue. So I've queued up all the dependent branches at https://github.com/kss-node/kss/branches/all?query=spec- and I'll push new PRs as we resolve open PRs. |
|
I-maintain-an-open-source-project-too-so-I-totally-understand-youre-not-getting-paid-to-review-my-pull-request-PING! :-) |
Here's the no-brainer spec clean-up bits (I hope!) from #106. I'll put the other changes in to their own PRs.
I kept them as separate commits, but I can rebase and squash them into 1 commit if you prefer.