Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to golang 1.21 and golang.org/x/mod v0.14.0 #25

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

ReToCode
Copy link
Member

Context

  • Bump to golang 1.21 and golang.org/x/mod v0.14.0

Fixes #24

/lint

/assign @skonto

@knative-prow knative-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 24, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@ReToCode
Copy link
Member Author

/override "style / Golang / Auto-format and Check"

Copy link

knative-prow bot commented Jan 24, 2024

@ReToCode: Overrode contexts on behalf of ReToCode: style / Golang / Auto-format and Check

In response to this:

/override "style / Golang / Auto-format and Check"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ReToCode
Copy link
Member Author

PTAL, discussion here

/assign @cardil
/assign @kvmware
/assign @psschwei
/assign @upodroid

Also this repo seems to be outdated with GH action sync and peribolos sync.

@knative knative deleted a comment from knative-prow bot Jan 24, 2024
@ReToCode
Copy link
Member Author

/assign @krsna-m

@dsimansk
Copy link
Contributor

/approve
/lgtm

For others
/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
Copy link

knative-prow bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2024
@krsna-m
Copy link
Contributor

krsna-m commented Jan 24, 2024

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2024
@knative-prow knative-prow bot merged commit e538037 into knative:main Jan 24, 2024
23 of 24 checks passed
@upodroid
Copy link
Member

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buoy fails with go 1.21 toolchain directive
7 participants