Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buoy: cut extra URL path for module #13

Merged
merged 1 commit into from
Jul 6, 2023
Merged

buoy: cut extra URL path for module #13

merged 1 commit into from
Jul 6, 2023

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Jul 6, 2023

Some module use sub-directory for the module like https://github.com/blang/semver/tree/master/v4

In that case, buoy fails to fetch metadata with the full path:

$ curl https://github.com/blang/semver/v4?go-get=1

so needs to use the top directory and path.

$ curl https://github.com/blang/semver?go-get=1

Hence, this patch cuts extra URL path for module.

Some module use sub-directory for the module like https://github.com/blang/semver/tree/master/v4

In that case, buoy fails to fetch metadata with the full path:

```
$ curl https://github.com/blang/semver/v4?go-get=1
```

so needs to use the top directory and path.

```
$ curl https://github.com/blang/semver?go-get=1
```

Hence, this patch cuts extra URL path for module.
@knative-prow knative-prow bot requested review from cardil and upodroid July 6, 2023 14:10
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 6, 2023
@nak3
Copy link
Contributor Author

nak3 commented Jul 6, 2023

Background issue is knative/pkg#2759 (comment)
I would like to use buoy to bump third-party library but it fails due to the issue.

@nak3
Copy link
Contributor Author

nak3 commented Jul 6, 2023

/cc @kvmware

@knative-prow knative-prow bot requested a review from krsna-m July 6, 2023 15:26
@knative-prow
Copy link

knative-prow bot commented Jul 6, 2023

@nak3: GitHub didn't allow me to request PR reviews from the following users: kv.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @kvmware @KV

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krsna-m
Copy link
Contributor

krsna-m commented Jul 6, 2023

/lgtm
@cardil or @upodroid want to give it another pair of eyes and /approve it?

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Jul 6, 2023

@nak3 note that the changes to hack you identified (in slack) will have to be done too if you want to pick up these changes

Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Don't forget to update knative/hack to use install bouy from this repo.

@knative-prow
Copy link

knative-prow bot commented Jul 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2023
@knative-prow knative-prow bot merged commit b204bbb into knative:main Jul 6, 2023
3 checks passed
@nak3 nak3 deleted the improve-buoy branch July 7, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants