Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move redirect app to the infra/gcp/dns folder #3250

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

chizhg
Copy link
Member

@chizhg chizhg commented Apr 11, 2022

This is a simple redirection app for redirecting subdomains in knative.dev, which was deployed in the knative-tests project. This PR moves it from our internal codebase to knative/test-infra and configures it to deploy in the knatve-dns project.

I have manually deployed it with make all command and confirmed it's working.

Part of #3134

/cc @kvmware @upodroid

@knative-prow knative-prow bot requested review from krsna-m and upodroid April 11, 2022 06:01
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 11, 2022
@krsna-m
Copy link
Contributor

krsna-m commented Apr 11, 2022

Can't we just do the redirect at the DNS layer?

@upodroid
Copy link
Member

Can't we just do the redirect at the DNS layer?

No. You want to redirect web requests.

  REDACTED  MCW0CDP3YY  ~  Desktop  Git  $  curl https://testgrid.knative.dev -IL -XGET
HTTP/2 302
content-type: text/html; charset=utf-8
cache-control: no-cache
location: https://testgrid.k8s.io/r/knative-own-testgrid
x-cloud-trace-context: cac0702326b56a9b560066185f209dc9;o=1
date: Mon, 11 Apr 2022 17:24:47 GMT
server: Google Frontend
content-length: 0

HTTP/2 200
x-appengine-log-flush-count: 0
content-type: text/html; charset=utf-8
x-cloud-trace-context: 9589e375c845cbf6c7f1227e5e6d3599
date: Mon, 11 Apr 2022 17:24:47 GMT
server: Google Frontend
content-length: 9711

Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2022
@knative-prow
Copy link

knative-prow bot commented Apr 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chizhg, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants