Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Use istio prowgen to generate Prow jobs (#3175)" #3178

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Revert "Use istio prowgen to generate Prow jobs (#3175)" #3178

merged 2 commits into from
Mar 23, 2022

Conversation

krsna-m
Copy link
Contributor

@krsna-m krsna-m commented Mar 23, 2022

This reverts commit 0656566.

What this PR does, why we need it:

codegen causing many problems org wide. https://knative.slack.com/archives/CCSNR4FCH/p1648044899588789

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 23, 2022
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2022
@knative-prow-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, kvmware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2022
@dprotaso
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2022
@dprotaso
Copy link
Member

/override pull-knative-test-infra-build-tests
/override pull-knative-test-infra-unit-tests

@knative-prow-robot
Copy link
Collaborator

@dprotaso: Overrode contexts on behalf of dprotaso: pull-knative-test-infra-build-tests, pull-knative-test-infra-unit-tests

In response to this:

/override pull-knative-test-infra-build-tests
/override pull-knative-test-infra-unit-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot merged commit 2332e82 into knative:main Mar 23, 2022
@knative-prow-robot
Copy link
Collaborator

@kvmware: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file prow/jobs/config.yaml
  • key async-component-main.gen.yaml using file ``
  • key container-freezer-main.gen.yaml using file ``
  • key discovery-main.gen.yaml using file ``
  • key eventing-autoscaler-keda-main.gen.yaml using file ``
  • key eventing-autoscaler-keda-release-1.0.gen.yaml using file ``
  • key eventing-autoscaler-keda-release-1.1.gen.yaml using file ``
  • key eventing-autoscaler-keda-release-1.2.gen.yaml using file ``
  • key eventing-autoscaler-keda-release-1.3.gen.yaml using file ``
  • key eventing-awssqs-main.gen.yaml using file ``
  • key eventing-awssqs-release-1.0.gen.yaml using file ``
  • key eventing-awssqs-release-1.1.gen.yaml using file ``
  • key eventing-awssqs-release-1.2.gen.yaml using file ``
  • key eventing-ceph-main.gen.yaml using file ``
  • key eventing-ceph-release-1.0.gen.yaml using file ``
  • key eventing-ceph-release-1.1.gen.yaml using file ``
  • key eventing-ceph-release-1.2.gen.yaml using file ``
  • key eventing-ceph-release-1.3.gen.yaml using file ``
  • key eventing-couchdb-main.gen.yaml using file ``
  • key eventing-couchdb-release-1.0.gen.yaml using file ``
  • key eventing-couchdb-release-1.1.gen.yaml using file ``
  • key eventing-github-main.gen.yaml using file ``
  • key eventing-github-release-1.0.gen.yaml using file ``
  • key eventing-github-release-1.1.gen.yaml using file ``
  • key eventing-github-release-1.2.gen.yaml using file ``
  • key eventing-github-release-1.3.gen.yaml using file ``
  • key eventing-gitlab-main.gen.yaml using file ``
  • key eventing-gitlab-release-1.0.gen.yaml using file ``
  • key eventing-gitlab-release-1.1.gen.yaml using file ``
  • key eventing-gitlab-release-1.2.gen.yaml using file ``
  • key eventing-gitlab-release-1.3.gen.yaml using file ``
  • key eventing-kafka-broker-main.gen.yaml using file ``
  • key eventing-kafka-broker-release-1.0.gen.yaml using file ``
  • key eventing-kafka-broker-release-1.1.gen.yaml using file ``
  • key eventing-kafka-broker-release-1.2.gen.yaml using file ``
  • key eventing-kafka-broker-release-1.3.gen.yaml using file ``
  • key eventing-kafka-main.gen.yaml using file ``
  • key eventing-kafka-release-1.0.gen.yaml using file ``
  • key eventing-kafka-release-1.1.gen.yaml using file ``
  • key eventing-kafka-release-1.2.gen.yaml using file ``
  • key eventing-kafka-release-1.3.gen.yaml using file ``
  • key eventing-kogito-main.gen.yaml using file ``
  • key eventing-kogito-release-1.0.gen.yaml using file ``
  • key eventing-kogito-release-1.1.gen.yaml using file ``
  • key eventing-kogito-release-1.2.gen.yaml using file ``
  • key eventing-kogito-release-1.3.gen.yaml using file ``
  • key eventing-natss-main.gen.yaml using file ``
  • key eventing-natss-release-1.0.gen.yaml using file ``
  • key eventing-natss-release-1.1.gen.yaml using file ``
  • key eventing-natss-release-1.2.gen.yaml using file ``
  • key eventing-natss-release-1.3.gen.yaml using file ``
  • key eventing-rabbitmq-main.gen.yaml using file ``
  • key eventing-rabbitmq-release-1.0.gen.yaml using file ``
  • key eventing-rabbitmq-release-1.1.gen.yaml using file ``
  • key eventing-rabbitmq-release-1.2.gen.yaml using file ``
  • key eventing-rabbitmq-release-1.3.gen.yaml using file ``
  • key eventing-redis-main.gen.yaml using file ``
  • key eventing-redis-release-1.0.gen.yaml using file ``
  • key eventing-redis-release-1.1.gen.yaml using file ``
  • key eventing-redis-release-1.2.gen.yaml using file ``
  • key eventing-redis-release-1.3.gen.yaml using file ``
  • key kn-plugin-admin-main.gen.yaml using file ``
  • key kn-plugin-admin-release-1.0.gen.yaml using file ``
  • key kn-plugin-admin-release-1.1.gen.yaml using file ``
  • key kn-plugin-admin-release-1.2.gen.yaml using file ``
  • key kn-plugin-admin-release-1.3.gen.yaml using file ``
  • key kn-plugin-diag-main.gen.yaml using file ``
  • key kn-plugin-event-main.gen.yaml using file ``
  • key kn-plugin-event-release-1.0.gen.yaml using file ``
  • key kn-plugin-event-release-1.1.gen.yaml using file ``
  • key kn-plugin-event-release-1.2.gen.yaml using file ``
  • key kn-plugin-event-release-1.3.gen.yaml using file ``
  • key kn-plugin-func-main.gen.yaml using file ``
  • key kn-plugin-migration-main.gen.yaml using file ``
  • key kn-plugin-operator-main.gen.yaml using file ``
  • key kn-plugin-quickstart-main.gen.yaml using file ``
  • key kn-plugin-quickstart-release-1.0.gen.yaml using file ``
  • key kn-plugin-quickstart-release-1.1.gen.yaml using file ``
  • key kn-plugin-quickstart-release-1.2.gen.yaml using file ``
  • key kn-plugin-quickstart-release-1.3.gen.yaml using file ``
  • key kn-plugin-sample-main.gen.yaml using file ``
  • key kn-plugin-service-log-main.gen.yaml using file ``
  • key kn-plugin-source-kafka-main.gen.yaml using file ``
  • key kn-plugin-source-kafka-release-1.0.gen.yaml using file ``
  • key kn-plugin-source-kafka-release-1.1.gen.yaml using file ``
  • key kn-plugin-source-kafka-release-1.2.gen.yaml using file ``
  • key kn-plugin-source-kafka-release-1.3.gen.yaml using file ``
  • key kn-plugin-source-kamelet-main.gen.yaml using file ``
  • key kn-plugin-source-kamelet-release-1.0.gen.yaml using file ``
  • key kn-plugin-source-kamelet-release-1.1.gen.yaml using file ``
  • key kn-plugin-source-kamelet-release-1.2.gen.yaml using file ``
  • key kn-plugin-source-kamelet-release-1.3.gen.yaml using file ``
  • key kperf-main.gen.yaml using file ``
  • key net-certmanager-main.gen.yaml using file ``
  • key net-certmanager-release-1.0.gen.yaml using file ``
  • key net-certmanager-release-1.1.gen.yaml using file ``
  • key net-certmanager-release-1.2.gen.yaml using file ``
  • key net-certmanager-release-1.3.gen.yaml using file ``
  • key net-contour-main.gen.yaml using file ``
  • key net-contour-release-1.0.gen.yaml using file ``
  • key net-contour-release-1.1.gen.yaml using file ``
  • key net-contour-release-1.2.gen.yaml using file ``
  • key net-contour-release-1.3.gen.yaml using file ``
  • key net-gateway-api-main.gen.yaml using file ``
  • key net-gateway-api-release-1.1.gen.yaml using file ``
  • key net-gateway-api-release-1.2.gen.yaml using file ``
  • key net-gateway-api-release-1.3.gen.yaml using file ``
  • key net-http01-main.gen.yaml using file ``
  • key net-http01-release-1.0.gen.yaml using file ``
  • key net-http01-release-1.1.gen.yaml using file ``
  • key net-http01-release-1.2.gen.yaml using file ``
  • key net-http01-release-1.3.gen.yaml using file ``
  • key net-istio-main.gen.yaml using file ``
  • key net-istio-release-1.0.gen.yaml using file ``
  • key net-istio-release-1.1.gen.yaml using file ``
  • key net-istio-release-1.2.gen.yaml using file ``
  • key net-istio-release-1.3.gen.yaml using file ``
  • key net-kourier-main.gen.yaml using file ``
  • key net-kourier-release-1.0.gen.yaml using file ``
  • key net-kourier-release-1.1.gen.yaml using file ``
  • key net-kourier-release-1.2.gen.yaml using file ``
  • key net-kourier-release-1.3.gen.yaml using file ``
  • key reconciler-test-main.gen.yaml using file ``
  • key sample-controller-main.gen.yaml using file ``
  • key sample-controller-release-1.0.gen.yaml using file ``
  • key sample-controller-release-1.1.gen.yaml using file ``
  • key sample-controller-release-1.2.gen.yaml using file ``
  • key sample-controller-release-1.3.gen.yaml using file ``
  • key sample-source-main.gen.yaml using file ``
  • key sample-source-release-1.0.gen.yaml using file ``
  • key sample-source-release-1.1.gen.yaml using file ``
  • key sample-source-release-1.2.gen.yaml using file ``
  • key sample-source-release-1.3.gen.yaml using file ``
  • key caching-main.gen.yaml using file ``
  • key client-main.gen.yaml using file ``
  • key client-pkg-main.gen.yaml using file ``
  • key client-release-1.0.gen.yaml using file ``
  • key client-release-1.1.gen.yaml using file ``
  • key client-release-1.2.gen.yaml using file ``
  • key client-release-1.3.gen.yaml using file ``
  • key docs-main.gen.yaml using file ``
  • key eventing-main.gen.yaml using file ``
  • key eventing-release-1.0.gen.yaml using file ``
  • key eventing-release-1.1.gen.yaml using file ``
  • key eventing-release-1.2.gen.yaml using file ``
  • key eventing-release-1.3.gen.yaml using file ``
  • key hack-main.gen.yaml using file ``
  • key networking-main.gen.yaml using file ``
  • key operator-main.gen.yaml using file ``
  • key operator-release-1.0.gen.yaml using file ``
  • key operator-release-1.1.gen.yaml using file ``
  • key operator-release-1.2.gen.yaml using file ``
  • key operator-release-1.3.gen.yaml using file ``
  • key pkg-main.gen.yaml using file ``
  • key serving-main.gen.yaml using file ``
  • key test-infra-main.gen.yaml using file ``

In response to this:

This reverts commit 0656566.

What this PR does, why we need it:

codegen causing many problems org wide. https://knative.slack.com/archives/CCSNR4FCH/p1648044899588789

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chizhg added a commit that referenced this pull request Mar 23, 2022
@chizhg
Revert "Revert "Use istio prowgen to generate Prow jobs (#3175)" (#3178…
d51ffd3 
…)"

This reverts commit 2332e82.
@chizhg chizhg mentioned this pull request Mar 23, 2022
Merged
chizhg added a commit that referenced this pull request Mar 23, 2022
@chizhg
Revert "Revert "Use istio prowgen to generate Prow jobs (#3175)" (#3178…
d4f404a 
…)"

This reverts commit 2332e82.
knative-prow-robot pushed a commit that referenced this pull request Mar 24, 2022
@chizhg
Revert "Revert "Use istio prowgen to generate Prow jobs (#3175)" (#3178…
287f71b 
…)" (#3179)

This reverts commit 2332e82.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krsna-m @dprotaso @knative-prow-robot