Skip to content

Comments

Revert "Update prow to v20200212-1f7b8ac1d"#1718

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
chizhg:revert-1716-autobump
Feb 18, 2020
Merged

Revert "Update prow to v20200212-1f7b8ac1d"#1718
knative-prow-robot merged 1 commit intoknative:masterfrom
chizhg:revert-1716-autobump

Conversation

@chizhg
Copy link
Contributor

@chizhg chizhg commented Feb 17, 2020

Boskos is broken after this update:

chizhg@chizhg-macbookpro:~/go/src/github.com/knative-prow-robot$ ku logs boskos-85f49fd654-9dxjb -n test-pods
E0217 23:44:28.890959       1 reflector.go:125] external/io_k8s_client_go/tools/cache/reflector.go:98: Failed to list *crds.DRLCObject: no kind "DRLCCollection" is registered for version "boskos.k8s.io/v1" in scheme "pkg/runtime/scheme.go:101"
E0217 23:44:28.896037       1 reflector.go:125] external/io_k8s_client_go/tools/cache/reflector.go:98: Failed to list *crds.ResourceObject: no kind "ResourceCollection" is registered for version "boskos.k8s.io/v1" in scheme "pkg/runtime/scheme.go:101"

/cc @chaodaiG

…and other images as necessary. (knative#1716)"

This reverts commit e48c4c6.
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 17, 2020
@knative-prow-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chizhg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2020
@chaodaiG
Copy link
Contributor

chaodaiG commented Feb 18, 2020 via email

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2020
@knative-prow-robot knative-prow-robot merged commit 9a26162 into knative:master Feb 18, 2020
peterfeifanchen pushed a commit to peterfeifanchen/test-infra that referenced this pull request Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants