More fixes to test-infra#158
Merged
knative-prow-robot merged 1 commit intoknative:masterfrom Oct 1, 2018
adrcunha:fix-go
Merged
More fixes to test-infra#158knative-prow-robot merged 1 commit intoknative:masterfrom adrcunha:fix-go
knative-prow-robot merged 1 commit intoknative:masterfrom
adrcunha:fix-go
Conversation
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
approved
Contributor
|
/lgtm |
Contributor
|
/lgtm |
Contributor
|
/test pull-knative-test-infra-integration-tests |
* Readd dummy.go to the root dir: Because we `dep` the root dir of `test-infra`, it must contain go code. * Ignore `kubetest` failures in `e2e-tests.sh`: Cluster teardown failures shouldn't affect the test results.
Contributor
|
/lgtm |
This was referenced Oct 1, 2018
knative-prow-robot
pushed a commit
to knative/serving
that referenced
this pull request
Oct 1, 2018
Unflake E2E tests due to teardown failures (knative/test-infra#158)
bbrowning
pushed a commit
to bbrowning/serving
that referenced
this pull request
Oct 5, 2018
Unflake E2E tests due to teardown failures (knative/test-infra#158)
Cynocracy
pushed a commit
to Cynocracy/test-infra
that referenced
this pull request
Jun 13, 2020
* add the commit id constant * add changeset lib * add doc.go with explanation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dummy.goto the root dir: Because wedepthe root dir oftest-infra, it must contain go code.kubetestfailures ine2e-tests.sh: Cluster teardown failures shouldn't affect the test results.