Use the same go test command for testing locally or on Prow#120
Merged
knative-prow-robot merged 1 commit intoknative:masterfrom Sep 20, 2018
adrcunha:align-go-test
Merged
Use the same go test command for testing locally or on Prow#120knative-prow-robot merged 1 commit intoknative:masterfrom adrcunha:align-go-test
knative-prow-robot merged 1 commit intoknative:masterfrom
adrcunha:align-go-test
Conversation
Until now, local runs would have slightly different command line parameters. This change will make the execution consistent between the environments, and also allow further experimentation on e2e tests, like testing the `-emit-metrics` flag locally.
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
size/S
Contributor
Author
|
/hold This PR must be tested (by Prow) and then merged after #119 is merged. |
knative-prow-robot
added
the
do-not-merge/hold
Contributor
|
/restest |
Contributor
Author
|
Needs rebase... |
Contributor
Author
|
Oh, /test pull-knative-test-infra-integration-tests |
Contributor
Author
|
/test pull-knative-test-infra-build-tests |
Contributor
Author
|
Tests passed, I inspected the logs, everything LGTM. Waiting for lgtm. :) /hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
Contributor
|
/lgtm |
Cynocracy
pushed a commit
to Cynocracy/test-infra
that referenced
this pull request
Jun 13, 2020
Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, local runs would have slightly different command line parameters.
This change will make the execution consistent between the environments, and also allow further experimentation on e2e tests, like testing the
-emit-metricsflag locally.