Remove createWithOptions shim for dry-run functionality

[markusthoemmes]

Proposed Changes

We have since moved to the 1.18 K8s clients so this workaround is no longer necessary and we can just use the K8s client proper.

Release Note

NONE

/assign @whaught @vagababov @julz

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/webhook/OWNERS [markusthoemmes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #9810 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #9810      +/-   ##
==========================================
+ Coverage   87.73%   87.75%   +0.02%     
==========================================
  Files         181      180       -1     
  Lines        8578     8570       -8     
==========================================
- Hits         7526     7521       -5     
+ Misses        803      801       -2     
+ Partials      249      248       -1     

Impacted Files	Coverage Δ
pkg/webhook/podspec_dryrun.go	75.00% <100.00%> (-0.87%)	⬇️
pkg/autoscaler/scaling/multiscaler.go	88.03% <0.00%> (-1.71%)	⬇️
pkg/reconciler/autoscaling/kpa/scaler.go	90.00% <0.00%> (+1.42%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ace4c8f...54bf3d5. Read the comment docs.

[julz]

/lgtm

[whaught]

Very exciting! I've been waiting for the day we could get rid of this hack!