Skip to content

Fixing issue where jobs do not complete on istio enabled cluster#8442

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
AceHack:istio-fix
Jun 23, 2020
Merged

Fixing issue where jobs do not complete on istio enabled cluster#8442
knative-prow-robot merged 1 commit intoknative:masterfrom
AceHack:istio-fix

Conversation

@AceHack
Copy link
Contributor

@AceHack AceHack commented Jun 23, 2020

Fixes #8441

Proposed Changes

  • Fixing issue where jobs do not complete on istio enabled cluster

Release Note

Fixes issue where migration jobs would fail on Istio cluster with auto-inject enabled

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 23, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 23, 2020
@AceHack
Copy link
Contributor Author

AceHack commented Jun 23, 2020

/assign @mdemirhan

@ar-mi6
Copy link

ar-mi6 commented Jun 23, 2020

I have the same issue as well. Let's approve this if we can!

@vagababov
Copy link
Contributor

/assign @tcnghia @dprotaso

@pinkeshsharma
Copy link

Can't wait for this to get merged, this will help a lot.

@sartian
Copy link

sartian commented Jun 23, 2020

This will be a big help if addressed.

@Cynocracy
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2020
@tcnghia
Copy link
Contributor

tcnghia commented Jun 23, 2020

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AceHack, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

storage-version-migration job never completes on istio enabled cluster