Use common const value for probe path#8316
Use common const value for probe path#8316knative-prow-robot merged 2 commits intoknative:masterfrom
Conversation
Autoscaler, activator and KIngres Prober commonly use the probe path `/healthz`, but they defined it in each package. This patch adds const value for ProbePath and use it from them. Related to knative#7445
knative-prow-robot
added
the
size/S
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@nak3: 1 warning.
Details
In response to this:
Proposed Changes
Autoscaler, activator and KIngres Prober commonly use the probe path
/healthz, but they defined it in each package.This patch adds const value for ProbePath and use it from them.
Related to #7445
/lint
Release Note
NONE
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
requested review from
chizhg,
julz,
taragu,
tcnghia and
yanweiguo
knative-prow-robot
added
area/API
|
The following is the coverage report on the affected files.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, nak3 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
6 participants
Proposed Changes
Autoscaler, activator and KIngres Prober commonly use the probe path
/healthz, but they defined it in each package.This patch adds const value for ProbePath and use it from them.
Related to #7445
/lint
Release Note