Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT SUBMIT] Test ko versions to find the buggy one #2745

Closed
wants to merge 9 commits into from
Closed

[DO NOT SUBMIT] Test ko versions to find the buggy one #2745

wants to merge 9 commits into from

Conversation

adrcunha
Copy link
Contributor

Test different versions of ko with Knative Serving.
/hold

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2018
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2018
@adrcunha
Copy link
Contributor Author

/test pull-knative-serving-integration-tests

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2018
@adrcunha
Copy link
Contributor Author

https://gubernator.knative.dev/build/knative-prow/pr-logs/pull/knative_serving/2745/pull-knative-serving-integration-tests/1074910056224395264/

Test failed, but not because of ko.

@adrcunha
Copy link
Contributor Author

https://gubernator.knative.dev/build/knative-prow/pr-logs/pull/knative_serving/2745/pull-knative-serving-integration-tests/1074917229314707457/

Test failed, but not because of ko.

@adrcunha
Copy link
Contributor Author

https://gubernator.knative.dev/build/knative-prow/pr-logs/pull/knative_serving/2745/pull-knative-serving-integration-tests/1074925534544138242/

Test failed with the BLOB_UNKNOWN error.

Probably culprit is google/go-containerregistry#297

@adrcunha adrcunha closed this Dec 18, 2018
@adrcunha adrcunha changed the title [DO NOT SUBMIT] Test ko [DO NOT SUBMIT] Test ko versions to find the buggy one Dec 18, 2018
@adrcunha adrcunha mentioned this pull request Dec 18, 2018
Closed
@adrcunha adrcunha reopened this Dec 18, 2018
@adrcunha
Copy link
Contributor Author

/retest

2 similar comments
@adrcunha
Copy link
Contributor Author

/retest

@adrcunha
Copy link
Contributor Author

/retest

@adrcunha
Copy link
Contributor Author

Tests failed, but not because of ko.

/retest

@adrcunha
Copy link
Contributor Author

All tests passed.

@adrcunha adrcunha closed this Dec 30, 2018
@adrcunha adrcunha deleted the test-klpo branch December 31, 2018 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dushyanthsc dushyanthsc Awaiting requested review from dushyanthsc

@srinivashegde86 srinivashegde86 Awaiting requested review from srinivashegde86

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrcunha @knative-prow-robot