Skip to content

Update knative/test-infra#2108

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
adrcunha:update-ti99
Sep 30, 2018
Merged

Update knative/test-infra#2108
knative-prow-robot merged 1 commit intoknative:masterfrom
adrcunha:update-ti99

Conversation

@adrcunha
Copy link
Copy Markdown
Contributor

@adrcunha adrcunha commented Sep 28, 2018

Major changes:

  • fixes to e2e-tests
  • better parsing of e2e tests

Major changes:
* fixes to e2e-tests
* better parsing of e2e tests
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 28, 2018
@adrcunha adrcunha requested review from mattmoor and srinivashegde86 and removed request for mattmoor and vaikas September 28, 2018 22:23
@srinivashegde86
Copy link
Copy Markdown
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2018
@adrcunha
Copy link
Copy Markdown
Contributor Author

The tests passed, cluster teardown had an error.

/retest

@mattmoor
Copy link
Copy Markdown
Member

/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2018
@knative-prow-robot knative-prow-robot merged commit 5bee9fa into knative:master Sep 30, 2018
bbrowning pushed a commit to bbrowning/serving that referenced this pull request Oct 5, 2018
Major changes:
* fixes to e2e-tests
* better parsing of e2e tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants