Vendor the test-infra scripts#1842
Merged
knative-prow-robot merged 1 commit intoknative:masterfrom Aug 14, 2018
adrcunha:vendor-test-infra-scripts-using-dep
Merged
Vendor the test-infra scripts#1842knative-prow-robot merged 1 commit intoknative:masterfrom adrcunha:vendor-test-infra-scripts-using-dep
knative-prow-robot merged 1 commit intoknative:masterfrom
adrcunha:vendor-test-infra-scripts-using-dep
Conversation
* shared scripts from test-infra live in //vendor/github.com/knative/test-infra/scripts; * update `update-deps.sh` to keep only the `scripts` folder; * all bash scripts were updated to use the vendored scripts;
knative-prow-robot
added
the
size/XL
adrcunha
requested review from
grantr and
mattmoor
and removed request for
vaikas
Contributor
Author
|
/hold knative/test-infra#78 and knative/test-infra#76 must be merged before this PR. Until knative/test-infra#76 is merged, the build tests will fail because the new dependency (test-infra) won't be fetchable. |
knative-prow-robot
added
the
do-not-merge/hold
Member
|
@adrcunha Is this ready for a look? |
Contributor
Author
|
/test pull-knative-serving-build-tests |
Contributor
Author
|
@mattmoor yes, it's now ready for review, thanks. |
Contributor
Author
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
bbrowning
pushed a commit
to bbrowning/serving
that referenced
this pull request
Oct 5, 2018
* shared scripts from test-infra live in //vendor/github.com/knative/test-infra/scripts; * update `update-deps.sh` to keep only the `scripts` folder; * all bash scripts were updated to use the vendored scripts;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update-deps.shto keep only thescriptsfolder;Part of knative/test-infra#30.