Link to kubernetes cluster doc #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
reviewed
Feb 14, 2018
DEVELOPMENT.md
Outdated
| @@ -31,6 +31,10 @@ You'll also need to setup: | |||
| kubectl create clusterrolebinding cluster-admin-binding \ | |||
| --clusterrole=cluster-admin --user=${YOUR_KUBE_USER} | |||
| ``` | |||
|
|
|||
| _See [`docs/creating-a-kubernetes-cluster.md`](./docs/creating-a-kubernetes-cluster.md) | |||
| for step-by-step instructions on setting up both GKE and minikube clusters._ | |||
There was a problem hiding this comment.
Can this replace the minikube link above?
DEVELOPMENT.md
Outdated
|
|
||
| _See [`docs/creating-a-kubernetes-cluster.md`](./docs/creating-a-kubernetes-cluster.md) | ||
| for step-by-step instructions on setting up both GKE and minikube clusters._ | ||
|
|
||
| 1. Kubernetes cluster must have MutatingAdmissionWebhook specified in the [--admission-control as per]: | ||
| (https://kubernetes.io/docs/admin/extensible-admission-controllers/#enable-external-admission-webhooks) |
There was a problem hiding this comment.
I still think this whole bullet belongs in the minikube section of your doc (or needs some qualification that it is minikube-only setup).
bobcatfish
approved these changes
Feb 14, 2018
DEVELOPMENT.md
Outdated
| @@ -31,6 +31,10 @@ You'll also need to setup: | |||
| kubectl create clusterrolebinding cluster-admin-binding \ | |||
| --clusterrole=cluster-admin --user=${YOUR_KUBE_USER} | |||
| ``` | |||
|
|
|||
| _See [`docs/creating-a-kubernetes-cluster.md`](./docs/creating-a-kubernetes-cluster.md) | |||
| for step-by-step instructions on setting up both GKE and minikube clusters._ | |||
mattmoor
reviewed
Feb 14, 2018
| ```bash | ||
| kubectl create clusterrolebinding cluster-admin-binding \ | ||
| --clusterrole=cluster-admin --user=${YOUR_KUBE_USER} | ||
| ``` |
There was a problem hiding this comment.
Is this command already in the "creating a cluster" docs?
There was a problem hiding this comment.
|
This PR now moves some of the k8s cluster setup instructions from |
Comments break copy-paste
mattmoor
approved these changes
Feb 14, 2018
matzew
pushed a commit
to matzew/serving
that referenced
this pull request
Jul 1, 2019
Add UID 65532 to run all containers as non-root user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to
docs/creating-a-kubernetes-cluster.mdfromDEVELOPMENT.md. I'm not picky about where this goes, so if someone has a better location or format, feel free to change it.