Sort conditions #1663
Merged
Sort conditions #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-prow-robot
added
the
size/L
google-prow-robot
added
the
approved
google-prow-robot
added
size/XL
mattmoor
force-pushed
the
sort-conditions
branch
from
0cc78e3 to
0e09994
Compare
google-prow-robot
added
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is so that the order of Conditions is stable and predictable.
This changes the type of LastTransitionTime fields to use a new VolatileTime type that is ignored by `equality.Semantic.DeepEqual`. This enables us to elide status updates that only update LastTransitionTime.
mattmoor
force-pushed
the
sort-conditions
branch
from
0e09994 to
7cafc03
Compare
|
/test pull-knative-serving-integration-tests |
tcnghia
reviewed
Jul 26, 2018
| @@ -95,7 +115,7 @@ type ConfigurationCondition struct { | |||
| Status corev1.ConditionStatus `json:"status" description:"status of the condition, one of True, False, Unknown"` | |||
|
|
|||
| // +optional | |||
| LastTransitionTime metav1.Time `json:"lastTransitionTime,omitempty" description:"last time the condition transit from one status to another"` | |||
| LastTransitionTime VolatileTime `json:"lastTransitionTime,omitempty" description:"last time the condition transit from one status to another"` | |||
There was a problem hiding this comment.
Add some comment explaining why we choose VolatileTime vs metav1.Time ?
mattmoor
force-pushed
the
sort-conditions
branch
from
7cafc03 to
426a9b4
Compare
|
The following is the coverage report on pkg/.
|
|
/lgtm |
mattmoor
added a commit
to mattmoor/serving
that referenced
this pull request
Jul 27, 2018
* Add sorting of the Service conditions. This is so that the order of Conditions is stable and predictable. * Add sorting of the Route conditions. * Add sorting of the Configuration conditions. * Add sorting of the Revision conditions. * Create a new VolatileTime type to wrap metav1.Time. This changes the type of LastTransitionTime fields to use a new VolatileTime type that is ignored by `equality.Semantic.DeepEqual`. This enables us to elide status updates that only update LastTransitionTime. * Make RevisionStatus use RevisionConditionSlice. * Update codegen.
ZhiminXiang
pushed a commit
to ZhiminXiang/serving-1
that referenced
this pull request
Aug 2, 2018
* Add sorting of the Service conditions. This is so that the order of Conditions is stable and predictable. * Add sorting of the Route conditions. * Add sorting of the Configuration conditions. * Add sorting of the Revision conditions. * Create a new VolatileTime type to wrap metav1.Time. This changes the type of LastTransitionTime fields to use a new VolatileTime type that is ignored by `equality.Semantic.DeepEqual`. This enables us to elide status updates that only update LastTransitionTime. * Make RevisionStatus use RevisionConditionSlice. * Update codegen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sorting to our
Conditions, and makeequality.Semanticignore theirLastTransitionTimefields.This change enables us to elide status updates when a
Reconcile()would only change the timestamp (and trigger another reconcile, potentially triggering an endless cycle).