Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --admission-control link #165

Closed
wants to merge 1 commit into from
Closed

Fix --admission-control link #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions DEVELOPMENT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ You'll also need to setup:
kubectl create clusterrolebinding cluster-admin-binding \
--clusterrole=cluster-admin --user=${YOUR_KUBE_USER}
```
1. Kubernetes cluster must have MutatingAdmissionWebhook specified in the [--admission-control as per]:
(https://kubernetes.io/docs/admin/extensible-admission-controllers/#enable-external-admission-webhooks)
1. Kubernetes cluster must have MutatingAdmissionWebhook specified with [--admission-control](https://kubernetes.io/docs/admin/extensible-admission-controllers/#enable-external-admission-webhooks).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this into minikube docs? This isn't even settable on GKE (in this way), and I think that leads to confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have any minikube docs yet. Does this mean we don't need this setting when we use GKE? I think we'd need it with other generic k8s clusters tho?

Maybe @vaikas-google can shed some light, I think he added this initially

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that you don't need this when using GKE.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started a thread to try and just get minikube fixed :) cc'd @bobcatfish

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubernetes/minikube#2547

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattmoor how do you feel about merging this fix for the link in the meantime (it's broken right now) or would you rather:

  1. leave it for now
  2. delete this line entirely for now

?

For example:
```bash
--admission-control=DenyEscalatingExec,LimitRanger,NamespaceExists,NamespaceLifecycle,ResourceQuota,ServiceAccount,DefaultStorageClass,SecurityContextDeny,MutatingAdmissionWebhook
Expand Down