Skip to content

Allow using serve mode with system-internal-tls #16183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow using serve mode with system-internal-tls #16183

wants to merge 2 commits into from

Conversation

@linkvt
Copy link

@linkvt linkvt commented Oct 21, 2025 •
edited
Loading

Hi,

related PR in networking: knative/networking#1093

Proposed Changes

  • Allow using Serve mode with system-internal-tls
    • right now Proxy mode is always forced when using system-internal-tls
    • we should allow disabling this behavior as some ingresses support validating certificates with multiple SANs and do not need to hop over the activator

Release Note

Allow using Serve mode when using system-internal-tls

Questions:

  1. Should this change result in a docs change, even if I marked it as alpha flag for now?

Thanks for the feedback!

/kind enhancement
/cc @Fedosin

@knative-prow knative-prow bot requested a review from Fedosin October 21, 2025 13:42
@knative-prow
Copy link

knative-prow bot commented Oct 21, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2025
@linkvt linkvt mentioned this pull request Oct 21, 2025
Open
@codecov
Copy link

codecov bot commented Oct 21, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.00%. Comparing base (2f3129a) to head (3099645).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16183      +/-   ##
==========================================
- Coverage   80.05%   80.00%   -0.06%     
==========================================
  Files         214      214              
  Lines       13281    13282       +1     
==========================================
- Hits        10632    10626       -6     
- Misses       2291     2298       +7     
  Partials      358      358

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2025
@Fedosin
Copy link
Contributor

Fedosin commented Oct 29, 2025

We'll likely need an e2e test for this scenario. Since this feature is expected to work with net-kourier, we can restrict the test environments to that specific Ingress controller.

@linkvt linkvt force-pushed the allow-serve-mode-with-internal-tls branch from 98fda9c to 99dbad5 Compare October 31, 2025 13:02
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2025
@linkvt
Allow serve mode with system-internal-tls
3099645 
When system-internal-tls is enabled, the KPA reconciler now checks the
SystemInternalTLSAllowServeMode flag to determine whether to use serve
mode or force proxy mode. This allows configurations where internal TLS
is enabled but serve mode is still desired.
@linkvt linkvt force-pushed the allow-serve-mode-with-internal-tls branch from 99dbad5 to 3099645 Compare October 31, 2025 13:10
@linkvt
Copy link
Author

linkvt commented Oct 31, 2025

I added an e2e test verifying this functionality and verified already locally that it works (both directions).

/hold until is knative/networking#1093 is merged, released and deps are updated
/remove-approve - was added automatically as I'm co-release lead.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2025
@linkvt linkvt marked this pull request as ready for review October 31, 2025 13:12
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fedosin Fedosin Awaiting requested review from Fedosin

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@linkvt @Fedosin @knative-prow-robot