Skip to content

Dump kubectl stderr when it fails in TestHelloWorldFromShell #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
google-prow-robot merged 1 commit into from
Jul 23, 2018
Merged

Dump kubectl stderr when it fails in TestHelloWorldFromShell #1587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/e2e/helloworld_shell_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@ func TestHelloWorldFromShell(t *testing.T) {
logger.Infof("Manifest file is '%s'", newYamlFilename)
logger.Info("Deploying using kubectl")

// Deply using kubectl
if err = exec.Command("kubectl", "apply", "-f", newYamlFilename).Run(); err != nil {
t.Fatalf("Error running kubectl: %v", err)
// Deploy using kubectl
if output, err := exec.Command("kubectl", "apply", "-f", newYamlFilename).CombinedOutput(); err != nil {
t.Fatalf("Error running kubectl: %v", strings.TrimSpace(string(output)))
}

logger.Info("Waiting for ingress to come up")
Expand Down