-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cold start time increase issue #15479
base: main
Are you sure you want to change the base?
Conversation
|
Welcome @kinderyj! It looks like this is your first PR to knative/serving 🎉 |
Hi @kinderyj. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kinderyj The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
// but ClusterIP conversely has been successfully probed. | ||
rw.podsAddressable = false | ||
if rw.meshMode == netcfg.MeshCompatibilityModeEnabled { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ReToCode thoughts on this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I'm not sure about all the implications here. Last time I did dig down that rabbithole, this flag had more effects than just that.
Also, instead of setting this, probably Activator should rather watch that config and reconfigure instead of needing the restart.
Fixes #15477
Proposed Changes
Release Note