Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cold start time increase issue #15479

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kinderyj
Copy link

Fixes #15477

Proposed Changes

  • For Kubernetes clusters without mesh enabled, it's preferable to probe the pod directly. However, if podsAddressable is set to false, the activator will continuously probe the cluster, leading to significantly longer cold start times. To re-enable pod probing, you must restart the activator pod. This is because the podsAddressable setting resets to its default value of true only during the activator's startup and initialization.

Release Note

Fix cold start time increase issue.

Copy link

linux-foundation-easycla bot commented Aug 22, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kinderyj / name: Matt Wang (bd35675)

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 22, 2024
Copy link

knative-prow bot commented Aug 22, 2024

Welcome @kinderyj! It looks like this is your first PR to knative/serving 🎉

Copy link

knative-prow bot commented Aug 22, 2024

Hi @kinderyj. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

knative-prow bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kinderyj
Once this PR has been reviewed and has the lgtm label, please assign davidhadas for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

// but ClusterIP conversely has been successfully probed.
rw.podsAddressable = false
if rw.meshMode == netcfg.MeshCompatibilityModeEnabled {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ReToCode thoughts on this one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I'm not sure about all the implications here. Last time I did dig down that rabbithole, this flag had more effects than just that.

Also, instead of setting this, probably Activator should rather watch that config and reconfigure instead of needing the restart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activatior issue: The cold start time significantly increases when rw.podsAddressable is set to false.
3 participants