-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify the description of ConfigMap config-defaults #14969
Modify the description of ConfigMap config-defaults #14969
Conversation
Welcome @KAZYPinkSaurus! It looks like this is your first PR to knative/serving 🎉 |
Hi @KAZYPinkSaurus. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
Thanks for the PR you'll need to run you'll need to run |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, KAZYPinkSaurus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14969 +/- ##
==========================================
- Coverage 84.23% 84.22% -0.02%
==========================================
Files 213 213
Lines 16635 16635
==========================================
- Hits 14013 14010 -3
- Misses 2277 2278 +1
- Partials 345 347 +2 ☔ View full report in Codecov by Sentry. |
TerminationGrace
Period
Seconds is more appropriate than terminationGraceTime
Seconds.The ConfigMap description probably explain about fallowing value.
serving/config/core/deployments/activator.yaml
Line 124 in 6dc7097
I believe this PR makes the comment more understandable.
Thank you.
Proposed Changes
Release Note