Skip to content

Add a private service name helper and use throughout#11176

Merged
knative-prow-robot merged 1 commit intoknative:mainfrom
markusthoemmes:priv-svc-name
Apr 14, 2021
Merged

Add a private service name helper and use throughout#11176
knative-prow-robot merged 1 commit intoknative:mainfrom
markusthoemmes:priv-svc-name

Conversation

@markusthoemmes
Copy link
Contributor

Proposed Changes

By popular demand, this adds a helper function to generate the private service name and makes use of it throughout the codebase.

Release Note

NONE

/assign @julz @vagababov

@knative-prow-robot knative-prow-robot added area/API API objects and controllers area/autoscale area/networking size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Apr 14, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 14, 2021
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #11176 (b416311) into main (fc6ca85) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #11176   +/-   ##
=======================================
  Coverage   87.69%   87.69%           
=======================================
  Files         190      191    +1     
  Lines        9194     9195    +1     
=======================================
+ Hits         8063     8064    +1     
+ Misses        877      876    -1     
- Partials      254      255    +1     
Impacted Files Coverage Δ
pkg/activator/handler/handler.go 95.65% <100.00%> (ø)
...onciler/serverlessservice/resources/names/names.go 100.00% <100.00%> (ø)
...reconciler/serverlessservice/resources/services.go 100.00% <100.00%> (ø)
.../reconciler/serverlessservice/serverlessservice.go 93.25% <100.00%> (ø)
pkg/autoscaler/statforwarder/leases.go 76.97% <0.00%> (-1.44%) ⬇️
pkg/activator/net/revision_backends.go 91.32% <0.00%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc6ca85...b416311. Read the comment docs.

Copy link
Contributor

@julz julz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2021
@markusthoemmes
Copy link
Contributor Author

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: julz, markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2021
@knative-prow-robot knative-prow-robot merged commit 7ac0c4f into knative:main Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants