Add a private service name helper and use throughout#11176
Merged
knative-prow-robot merged 1 commit intoknative:mainfrom Apr 14, 2021
Merged
Add a private service name helper and use throughout#11176knative-prow-robot merged 1 commit intoknative:mainfrom
knative-prow-robot merged 1 commit intoknative:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #11176 +/- ##
=======================================
Coverage 87.69% 87.69%
=======================================
Files 190 191 +1
Lines 9194 9195 +1
=======================================
+ Hits 8063 8064 +1
+ Misses 877 876 -1
- Partials 254 255 +1
Continue to review full report at Codecov.
|
Contributor
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz, markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
By popular demand, this adds a helper function to generate the private service name and makes use of it throughout the codebase.
Release Note
/assign @julz @vagababov