Skip to content

Revision return replicas #11038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 13 commits into from
Apr 7, 2021
Merged

Revision return replicas #11038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cbe8426
add PodAutoScaler information to revision status
leetcope Feb 24, 2021
40928ab
handle PodAutoscaler inactive for Revision status
leetcope Feb 24, 2021
64668fa
refactor Revision PodAutoScaler replicas status test
leetcope Feb 25, 2021
39e0514
refactor Revision status test to subtests
leetcope Feb 25, 2021
048a910
assert new replica values for Revision in helloworld_test
leetcope Mar 26, 2021
8235d0b
assert new replica values for Revision in minscale_readiness_test
leetcope Mar 26, 2021
a5ea564
remove unnecessary output
leetcope Mar 26, 2021
10c5cc1
remove desired replicas assertion
leetcope Mar 26, 2021
b37b9d8
address PR feedback
leetcope Mar 26, 2021
5a4cc32
reflect revision API change in CRD
leetcope Mar 26, 2021
4c1cdc5
handle error and replica assertion in distinct checks
leetcope Mar 29, 2021
b2493b8
fix misspelled "occurred"
leetcope Mar 29, 2021
7abff9f
tidy up if blocks
leetcope Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions config/core/300-resources/revision.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,12 @@ spec:
- name: Reason
type: string
jsonPath: ".status.conditions[?(@.type=='Ready')].reason"
- name: Actual Replicas
type: integer
jsonPath: ".status.actualReplicas"
- name: Desired Replicas
type: integer
jsonPath: ".status.desiredReplicas"
names:
kind: Revision
plural: revisions
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ require (
k8s.io/code-generator v0.19.7
k8s.io/gengo v0.0.0-20201214224949-b6c5ce23f027 // indirect
k8s.io/kube-openapi v0.0.0-20210113233702-8566a335510f
k8s.io/utils v0.0.0-20210111153108-fddb29f9d009 // indirect
k8s.io/utils v0.0.0-20210111153108-fddb29f9d009
knative.dev/caching v0.0.0-20210331063521-5691bb38d441
knative.dev/hack v0.0.0-20210325223819-b6ab329907d3
knative.dev/networking v0.0.0-20210331064822-999a7708876c
Expand Down
Loading