Add new TLS-related conditions to DomainMapping condset#10248
Merged
knative-prow-robot merged 3 commits intoknative:masterfrom Dec 9, 2020
Merged
Add new TLS-related conditions to DomainMapping condset#10248knative-prow-robot merged 3 commits intoknative:masterfrom
knative-prow-robot merged 3 commits intoknative:masterfrom
Conversation
knative-prow-robot
added
size/L
knative-prow-robot
added
the
approved
Contributor
Author
tcnghia
requested review from
YoussB,
asyoussef and
julz
and removed request for
asyoussef,
markusthoemmes and
whaught
Codecov Report
@@ Coverage Diff @@
## master #10248 +/- ##
==========================================
+ Coverage 88.10% 88.15% +0.04%
==========================================
Files 184 184
Lines 8619 8635 +16
==========================================
+ Hits 7594 7612 +18
Misses 787 787
+ Partials 238 236 -2
Continue to review full report at Codecov.
|
Co-authored-by: Julian Friedman <julz.friedman@uk.ibm.com>
Contributor
Author
|
/hold |
knative-prow-robot
added
the
do-not-merge/hold
Contributor
|
/lgtm |
YoussB
approved these changes
Dec 8, 2020
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz, tcnghia, YoussB The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of #10247
Proposed Changes
Release Note