Start executing rollout steps in the ingress reconcile#10106
Merged
knative-prow-robot merged 3 commits intoknative:masterfrom Nov 16, 2020
Merged
Start executing rollout steps in the ingress reconcile#10106knative-prow-robot merged 3 commits intoknative:masterfrom
knative-prow-robot merged 3 commits intoknative:masterfrom
Conversation
- This applies rolledout reconcile to the annotaion (no ingress spec changes yet) - Moved the appllication from the createingress to route controller — since we need to compute diffs which makes things easier this way, because to do rollout we need to compare previous with the new one. Change-Id: Iff42c7b5498e76ca0777908cac82f09b4c9794ca
knative-prow-robot
added
size/L
Codecov Report
@@ Coverage Diff @@
## master #10106 +/- ##
==========================================
- Coverage 87.98% 87.96% -0.03%
==========================================
Files 185 185
Lines 8717 8733 +16
==========================================
+ Hits 7670 7682 +12
- Misses 797 799 +2
- Partials 250 252 +2
Continue to review full report at Codecov.
|
Change-Id: I93082a41053183380589aa168e8355a2e282cb38
Contributor
Author
|
fixed the lint issues |
Contributor
Author
|
/retest |
Contributor
Author
|
/test pull-knative-serving-upgrade-tests |
Contributor
Author
|
/retest |
3 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
julz
reviewed
Nov 16, 2020
| func serializeRollout(ctx context.Context, r *traffic.Rollout) string { | ||
| sr, err := json.Marshal(r) | ||
| if err != nil { | ||
| // This must not never happen in the normal course of things. |
Contributor
There was a problem hiding this comment.
super nit but I think this is a double negative and you actually want to say
Suggested change
| // This must not never happen in the normal course of things. | |
| // This should never happen in the normal course of things. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/retest |
yangyunfeng007
pushed a commit
to yangyunfeng007/serving
that referenced
this pull request
Nov 19, 2020
* Start executing rollout steps in the ingress reconcile - This applies rolledout reconcile to the annotaion (no ingress spec changes yet) - Moved the appllication from the createingress to route controller — since we need to compute diffs which makes things easier this way, because to do rollout we need to compare previous with the new one. Change-Id: Iff42c7b5498e76ca0777908cac82f09b4c9794ca * use named fields Change-Id: I93082a41053183380589aa168e8355a2e282cb38 * nit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which makes things easier this way, because to do rollout we need to compare previous with the new one.
/assign @tcnghia mattmoor
For #9766