Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump k8s to v1.20.7 #2145

Merged
merged 14 commits into from
Jun 10, 2021
Merged

bump k8s to v1.20.7 #2145

merged 14 commits into from
Jun 10, 2021

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Jun 4, 2021

Fixes: #2111

@knative-prow-robot knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 4, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 4, 2021
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2021
@dprotaso dprotaso changed the title bump k8s to v1.20 bump k8s to v1.20.7 Jun 4, 2021
@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #2145 (2a46e22) into main (0f304f6) will decrease coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2145      +/-   ##
==========================================
- Coverage   65.89%   65.82%   -0.07%     
==========================================
  Files         221      221              
  Lines        9344     9362      +18     
==========================================
+ Hits         6157     6163       +6     
- Misses       2914     2923       +9     
- Partials      273      276       +3     
Impacted Files Coverage Δ
injection/clients/dynamicclient/fake/fake.go 64.28% <50.00%> (-35.72%) ⬇️
test/gcs/mock/mock.go 91.39% <0.00%> (-1.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f304f6...2a46e22. Read the comment docs.

@dprotaso
Copy link
Member Author

dprotaso commented Jun 7, 2021

/hold

I'm going to try to make a shim client that preserved pre 1.20 dynamic client behaviour

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2021
@dprotaso
Copy link
Member Author

dprotaso commented Jun 7, 2021

hmm... that won't work cause they make a copy of gvrToList map

@dprotaso
Copy link
Member Author

dprotaso commented Jun 8, 2021

This PR should make eventing green: knative/eventing#5477 downstream.

Other changes are trivial string replacements with the exception of the client & a plugin

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2021
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2021
@dprotaso
Copy link
Member Author

dprotaso commented Jun 9, 2021

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2021
@dprotaso
Copy link
Member Author

dprotaso commented Jun 9, 2021

/assign @n3wscott @markusthoemmes

@markusthoemmes
Copy link
Contributor

Doublechecked the downstream failures:

  • Serving has the same "different error message" thing that this has, trivial to fix
  • Networking has the same.
  • Client has a compile error. Would it make sense to stage that change first?
  • Camel has already been dropped, so we can ignore.
  • kn-plugin-admin has the same compile error as client, so I guess fixing client will fix it as well.

So this is LGTM! Thanks for unblocking that breaking change!

@markusthoemmes
Copy link
Contributor

FWIW, just looked at the client failure: k8s.io/cli-runtime has to be bumped to 0.20.7 in that repo too (it's not inherited from here) and then a few tests fail due to that dynamic client breaking change. Alerted the client team about that and now waiting for confirmation to either go ahead or to stage a fix first.

Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dprotaso,markusthoemmes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit eaa823c into knative:main Jun 10, 2021
@dprotaso dprotaso deleted the bump-k8s branch June 10, 2021 13:56
knative-prow-robot pushed a commit to knative-extensions/net-istio that referenced this pull request Jun 11, 2021
The k8s lib was pinned by #569.

Now pkg bumped to 1.20.7 by knative/pkg#2145
so let's drop the pin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump k8s libs to 1.20 or 1.21
4 participants