Mutate - to _ in component names for metrics (#1145) (#1146)

knative · Mar 6, 2020 · a56a6ea · a56a6ea
1 parent 122514b
commit a56a6ea
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/metrics/exporter.go b/metrics/exporter.go
@@ -16,6 +16,7 @@ package metrics
 import (
 	"errors"
 	"fmt"
+	"strings"
 	"sync"
 
 	"go.opencensus.io/stats/view"
@@ -74,7 +75,7 @@ func UpdateExporterFromConfigMap(component string, logger *zap.SugaredLogger) fu
 	return func(configMap *corev1.ConfigMap) {
 		UpdateExporter(ExporterOptions{
 			Domain:    domain,
-			Component: component,
+			Component: strings.ReplaceAll(component, "-", "_"),
 			ConfigMap: configMap.Data,
 		}, logger)
 	}

diff --git a/metrics/exporter_test.go b/metrics/exporter_test.go
@@ -84,6 +84,17 @@ func TestMetricsExporter(t *testing.T) {
 			},
 		},
 		expectSuccess: true,
+	}, {
+		name: "validConfigWithDashInName",
+		config: &metricsConfig{
+			domain:             servingDomain,
+			component:          "test-component",
+			backendDestination: Stackdriver,
+			stackdriverClientConfig: StackdriverClientConfig{
+				ProjectID: "testProj",
+			},
+		},
+		expectSuccess: true,
 	}, {
 		name: "stackdriverConfigOnly",
 		config: &metricsConfig{