Backward compatibility for InternalEncryption#806
Backward compatibility for InternalEncryption#806knative-prow[bot] merged 2 commits intoknative:mainfrom
Conversation
|
@davidhadas Could you fix the unit test? |
|
And this must be merged after knative/serving#13969 ? |
The idea was to merge before it actually :) |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #806 +/- ##
==========================================
+ Coverage 94.57% 94.59% +0.02%
==========================================
Files 41 41
Lines 1253 1259 +6
==========================================
+ Hits 1185 1191 +6
Misses 56 56
Partials 12 12
☔ View full report in Codecov by Sentry. |
|
/lgtm Thank you! Okay, please unhold this when the good timing. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidhadas, nak3 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Ensure that if someone uses the deprecated InternalEncryption, we use Dataplane-trust=Minimal as a minimum.
InternalEncryption is deprecated but will take time to remove from dependencies