Skip to content

Backward compatibility for InternalEncryption#806

Merged
knative-prow[bot] merged 2 commits intoknative:mainfrom
davidhadas:backwardCompatibilty
May 11, 2023
Merged

Backward compatibility for InternalEncryption#806
knative-prow[bot] merged 2 commits intoknative:mainfrom
davidhadas:backwardCompatibilty

Conversation

@davidhadas
Copy link
Contributor

Ensure that if someone uses the deprecated InternalEncryption, we use Dataplane-trust=Minimal as a minimum.
InternalEncryption is deprecated but will take time to remove from dependencies

@knative-prow knative-prow bot requested review from izabelacg and jsanin-vmw May 10, 2023 06:36
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 10, 2023
@nak3
Copy link
Contributor

nak3 commented May 11, 2023

@davidhadas Could you fix the unit test?

@nak3
Copy link
Contributor

nak3 commented May 11, 2023

And this must be merged after knative/serving#13969 ?

@davidhadas
Copy link
Contributor Author

davidhadas commented May 11, 2023

And this must be merged after #13969

The idea was to merge before it actually :)
The intention is to ensure that when we merge #13969, and a cluster has InternalEncryption=true, we will behave as well as we already do today.

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (77975a1) 94.57% compared to head (f1dfc74) 94.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
+ Coverage   94.57%   94.59%   +0.02%     
==========================================
  Files          41       41              
  Lines        1253     1259       +6     
==========================================
+ Hits         1185     1191       +6     
  Misses         56       56              
  Partials       12       12              
Impacted Files Coverage Δ
pkg/config/config.go 84.94% <100.00%> (+0.50%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nak3
Copy link
Contributor

nak3 commented May 11, 2023

/lgtm
/approve
/hold

Thank you! Okay, please unhold this when the good timing.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2023
@knative-prow
Copy link

knative-prow bot commented May 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidhadas, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2023
@davidhadas
Copy link
Contributor Author

/unhold
This change will be useful once we start changing InternalEncryption across Serving packages to DataPlane-Trust. It will ensure that if InternalEncryption=true, such changes will not affect us by having some of the packages controlled by InternalEncryption and some by DataPlane-Trust.

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2023
@knative-prow knative-prow bot merged commit 33636d9 into knative:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants