Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow sub-pkgs in Go functions #2523

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

matejvasek
Copy link
Contributor

Changes

/kind

Fixes #

Release Note


Docs


Copy link

knative-prow bot commented Sep 26, 2024

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2024
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.86%. Comparing base (e4d9b3d) to head (4edad69).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2523      +/-   ##
==========================================
+ Coverage   61.43%   66.86%   +5.43%     
==========================================
  Files         130      130              
  Lines       15479    12048    -3431     
==========================================
- Hits         9509     8056    -1453     
+ Misses       5029     3014    -2015     
- Partials      941      978      +37     
Flag Coverage Δ
e2e-test 36.55% <50.00%> (ø)
e2e-test-oncluster 33.36% <0.00%> (+<0.01%) ⬆️
e2e-test-oncluster-runtime 29.65% <0.00%> (?)
e2e-test-runtime-go 26.56% <0.00%> (?)
e2e-test-runtime-node 25.95% <0.00%> (?)
e2e-test-runtime-python 25.95% <0.00%> (?)
e2e-test-runtime-quarkus 26.05% <0.00%> (?)
e2e-test-runtime-rust 25.04% <0.00%> (?)
e2e-test-runtime-springboot 25.12% <0.00%> (?)
e2e-test-runtime-typescript 26.04% <0.00%> (?)
integration-tests 53.04% <50.00%> (+2.35%) ⬆️
unit-tests 51.65% <100.00%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Matej Vašek <[email protected]>
@matejvasek matejvasek requested review from lkingland, matzew and gauron99 and removed request for nainaz September 26, 2024 17:18
Signed-off-by: Matej Vašek <[email protected]>
Signed-off-by: Matej Vašek <[email protected]>
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 26, 2024
@matejvasek
Copy link
Contributor Author

@lkingland at three places in the code go get f(unction) is/was called, what is reason for that? Does not go build automatically pulls modules? Also if antying shouldn't we rather call go mod download so all deps are downloaded?

@matejvasek
Copy link
Contributor Author

PTAL @lkingland

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2024
Copy link

knative-prow bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 075bc9b into knative:main Sep 27, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants