Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: spring boot dependency updater #1896

Merged
merged 4 commits into from
Aug 3, 2023
Merged

fix: spring boot dependency updater #1896

merged 4 commits into from
Aug 3, 2023

Conversation

matejvasek
Copy link
Contributor

Changes

  • 🐛 Fix spring boot dependency updater.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 1, 2023
@knative-prow knative-prow bot requested review from dsimansk and nainaz August 1, 2023 19:40
@matejvasek
Copy link
Contributor Author

PTAL @trisberg

@matejvasek matejvasek requested review from salaboy, gauron99 and aslom and removed request for dsimansk and nainaz August 1, 2023 19:40
@matejvasek
Copy link
Contributor Author

PTAL @ningyan325

@codecov
Copy link

codecov bot commented Aug 1, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +2.08% 🎉

Comparison is base (6eac0d0) 60.68% compared to head (1c1a35f) 62.76%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1896      +/-   ##
==========================================
+ Coverage   60.68%   62.76%   +2.08%     
==========================================
  Files         107      107              
  Lines       13827    13827              
==========================================
+ Hits         8391     8679     +288     
+ Misses       4606     4266     -340     
- Partials      830      882      +52
Flag Coverage Δ
e2e-test 35.46% <ø> (ø)
e2e-test-oncluster 30.77% <ø> (?)
e2e-test-oncluster-runtime 25.63% <ø> (?)
e2e-test-runtime-go 25.82% <ø> (?)
e2e-test-runtime-node 26.90% <ø> (?)
e2e-test-runtime-python 26.90% <ø> (?)
e2e-test-runtime-quarkus 27.02% <ø> (?)
e2e-test-runtime-springboot 26.04% <ø> (?)
e2e-test-runtime-typescript 27.02% <ø> (?)
integration-tests 51.43% <ø> (+2.17%) ⬆️
unit-tests-macos-latest 48.62% <ø> (ø)
unit-tests-ubuntu-latest 49.40% <ø> (ø)
unit-tests-windows-latest 48.64% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkingland
Copy link
Member

/lgtm
/hold for the requested reviewers to take a look

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2023
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 3, 2023
@matejvasek
fixup: install new deps
0ec9f89 
Signed-off-by: Matej Vasek <[email protected]>
@matejvasek
Copy link
Contributor Author

PTAL @trisberg

@matejvasek
fixup: clean up
1c1a35f 
Signed-off-by: Matej Vasek <[email protected]>
trisberg
trisberg approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@trisberg trisberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, trisberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek
Copy link
Contributor Author

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@knative-prow knative-prow bot merged commit fc2c045 into knative:main Aug 3, 2023
33 checks passed
@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trisberg trisberg trisberg approved these changes

@salaboy salaboy Awaiting requested review from salaboy

@gauron99 gauron99 Awaiting requested review from gauron99

@aslom aslom Awaiting requested review from aslom

@lkingland lkingland Awaiting requested review from lkingland

Assignees

@trisberg trisberg

@lkingland lkingland

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matejvasek @lkingland @trisberg