Skip to content

Commit

Permalink
test: making e2e config tests builder agnostic
Browse files Browse the repository at this point in the history
  • Loading branch information
jrangelramos committed Oct 7, 2024
1 parent 35eb3a4 commit 8192464
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion test/e2e/scenario_config-envs_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ func TestConfigEnvs(t *testing.T) {

// Deploy
knFunc.TestCmd.WithEnv(testEnvName, testEnvValue)
knFunc.TestCmd.Exec("deploy", "--builder", "pack", "--registry", common.GetRegistry())
knFunc.TestCmd.Exec("deploy", "--registry", common.GetRegistry())
defer knFunc.TestCmd.Exec("delete")
_, functionUrl := common.WaitForFunctionReady(t, funcName)

Expand Down
2 changes: 1 addition & 1 deletion test/e2e/scenario_config-labels_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func TestConfigLabel(t *testing.T) {
// Deploy
knFunc.TestCmd.
WithEnv(testEnvName, testEnvValue).
Exec("deploy", "--registry", common.GetRegistry(), "--builder", "pack")
Exec("deploy", "--registry", common.GetRegistry())
defer knFunc.TestCmd.Exec("delete")

// Then assert that...
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/scenario_config-volumes_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ func TestConfigVolumes(t *testing.T) {
configVolumesRemove("/bad-cm", enter)

// Deploy
knFunc.TestCmd.Exec("deploy", "--builder", "pack", "--registry", common.GetRegistry())
knFunc.TestCmd.Exec("deploy", "--registry", common.GetRegistry())
defer knFunc.TestCmd.Exec("delete")
_, functionUrl := common.WaitForFunctionReady(t, funcName)

Expand Down Expand Up @@ -271,7 +271,7 @@ func TestConfigVolumesPvcEmptyDir(t *testing.T) {

// Deploy

knFunc.TestCmd.Exec("deploy", "--builder", "pack", "--registry", common.GetRegistry())
knFunc.TestCmd.Exec("deploy", "--registry", common.GetRegistry())
t.Cleanup(func() {
knFunc.TestCmd.Exec("delete")
})
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/scenario_remote-repository_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ func TestRemoteRepository(t *testing.T) {

knFunc.SourceDir = funcPath

knFunc.Exec("deploy", "--builder", "pack", "--registry", common.GetRegistry())
knFunc.Exec("deploy", "--registry", common.GetRegistry())
defer knFunc.Exec("delete")
_, functionUrl := common.WaitForFunctionReady(t, funcName)

Expand Down

0 comments on commit 8192464

Please sign in to comment.