-
Notifications
You must be signed in to change notification settings - Fork 631
Authenticate Requests from ApiServerSources #7452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
knative-prow
merged 73 commits into
knative:main
from
Leo6Leo:authenticate-request-from-apiserversource
Dec 18, 2023
Merged
Changes from 1 commit
Commits
Show all changes
73 commits
Select commit
Hold shift + click to select a range
e2092b0
Add the task planning toughts to the PR
Leo6Leo 2369d50
Merge branch 'main' into authenticate-request-from-apiserversource
Leo6Leo 48c349f
add the auth header to all the send and request to the adapter
Leo6Leo 0e83dbc
Merge branch 'main' into authenticate-request-from-apiserversource
Leo6Leo e7b38a8
Adding the env var for K_AUDIENCE
Leo6Leo 8efcee8
Adding the rekt test
Leo6Leo aea806a
Merge the upstream main branch
Leo6Leo e11c5e9
Adding the rolebinding for create_oidc
Leo6Leo 8b4463c
Adding the rolebinding for create_oidc
Leo6Leo ef855c8
Update the env variable
Leo6Leo 5c134b3
Revert the automated change to the file
Leo6Leo 4d3caec
Update pkg/adapter/apiserver/delegate.go
Leo6Leo 0cab4e5
Apply suggestions from code review
Leo6Leo c6a9d54
Merge the upstream main branch
Leo6Leo 7190e7e
Save the working progress - 2
Leo6Leo 8863654
Save the work progress, as everything is working right now. Next, wil…
Leo6Leo 5b9fbc2
Fix the format issue (wrong indentation) the yaml file
Leo6Leo f49c7fc
Refactored and test passed
Leo6Leo 012dece
Refactored and test passed
Leo6Leo fb01dde
Remove all the logs
Leo6Leo 08780d4
Go imports
Leo6Leo 31756fd
Merge branch 'main' into authenticate-request-from-apiserversource
Leo6Leo 72735a3
revert the wrong format change during the merging
Leo6Leo 8bfb205
Self sanity check before requesting review
Leo6Leo d125209
Fix the failed unit test
Leo6Leo 34f0f2c
Merge branch 'main' into authenticate-request-from-apiserversource
Leo6Leo 55e5c30
Fix the review comments
Leo6Leo a3c9ca8
Update test/auth/features/oidc/apiserversource.go
Leo6Leo a924341
Apply suggestions from code review
Leo6Leo 751deaa
Fix the nit error
Leo6Leo 37e41a8
Move the MakeOIDCRoleBinding() and MakeOIDCRole() to a separate file
Leo6Leo 6861c83
Handle the role and rolebinding update
Leo6Leo 610ba92
Merge branch 'main' into authenticate-request-from-apiserversource
Leo6Leo af5e3c0
Fix the typo
Leo6Leo dcc0dd0
Update pkg/adapter/v2/cloudevents.go
Leo6Leo 8474dbe
Update pkg/adapter/v2/cloudevents.go
Leo6Leo be9f52d
Update pkg/adapter/v2/config.go
Leo6Leo 12cbf55
Update pkg/reconciler/apiserversource/resources/oidc_rolebinding.go
Leo6Leo 43dbcfb
Update pkg/reconciler/apiserversource/resources/receive_adapter.go
Leo6Leo 2e3191c
Update pkg/adapter/v2/config.go
Leo6Leo d8a8b53
Update pkg/adapter/v2/config.go
Leo6Leo a746850
Update pkg/reconciler/apiserversource/resources/oidc_rolebinding.go
Leo6Leo 0630d3a
Fix the majority of the review comments except for the role lister.
Leo6Leo 8961e96
Fix the majority of the review comments except for the role lister.
Leo6Leo 6821cd0
Gofmt and goimports
Leo6Leo 7b87e70
Update the injection dependency
Leo6Leo 4a68425
Use roleLister and roleBindingLister
Leo6Leo 13cc267
Apply suggestions from code review
Leo6Leo 36e70be
Update the nit function name change
Leo6Leo 277af48
Fix the failed unit test by adding the OIDC component, and add the ne…
Leo6Leo c1248ea
Pass in the fake kubeclinet to apiserversource
Leo6Leo da14390
Apply suggestions from code review
Leo6Leo 3f0265d
nit fix
Leo6Leo d599e64
nit fix
Leo6Leo d0b400e
Fix the failed unit test: no audience is passed in
Leo6Leo f67e906
nit: boilerplate format
Leo6Leo a9ec39e
Merge branch 'main' into authenticate-request-from-apiserversource
Leo6Leo bf4c727
Change the comment and re-order the code according to the review comment
Leo6Leo 81b54c4
Merge the main branch and resolve the merge conflict
Leo6Leo 479aa7f
Change to use the filtered informer, and add the informer eventhandle…
Leo6Leo 35c43b6
Change to use the filtered informer, and add the informer eventhandle…
Leo6Leo 757880e
Merge branch 'main' into authenticate-request-from-apiserversource
Leo6Leo c8254e5
Inject the oidcSelector in the main.go
Leo6Leo 30b7d22
Add the owner reference to the role and rolebinding
Leo6Leo 72b37ed
Update the tests
Leo6Leo 55c1724
Update the tests
Leo6Leo 0d053b3
nit fix
Leo6Leo c082ede
register the selectors
Leo6Leo 62fe570
nit: fix the go imports
Leo6Leo a8de8b8
Merge branch 'main' into authenticate-request-from-apiserversource
Leo6Leo f8b4795
nit: renaming the variables and only filter on the labelKey (e.g. by …
Leo6Leo a73a26b
nit: renaming the variables and only filter on the labelKey (e.g. by …
Leo6Leo 8890c5d
nit: fix the naming and add - to the create-oidc-token
Leo6Leo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.