-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Now MessageReceiver serves unbuffered messages and fanout buffers them #2773
Conversation
Signed-off-by: Francesco Guardiani <[email protected]>
Signed-off-by: Francesco Guardiani <[email protected]>
Signed-off-by: Francesco Guardiani <[email protected]>
Signed-off-by: Francesco Guardiani <[email protected]>
The following is the coverage report on the affected files.
|
/retest |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n3wscott, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The rationale behind this change is to avoid unnecessary buffering for KafkaChannel, which just needs to transcode the received message to a kafka ProducerMessage
Signed-off-by: Francesco Guardiani [email protected]
Fixes #
Proposed Changes
fanout.MessageHandler
performs the message bufferingMessageReceiver
calls the handler with an unbuffered message