Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now MessageReceiver serves unbuffered messages and fanout buffers them #2773

Merged
merged 4 commits into from
Mar 18, 2020

Conversation

slinkydeveloper
Copy link
Contributor

The rationale behind this change is to avoid unnecessary buffering for KafkaChannel, which just needs to transcode the received message to a kafka ProducerMessage

Signed-off-by: Francesco Guardiani [email protected]

Fixes #

Proposed Changes

  • Now fanout.MessageHandler performs the message buffering
  • Now MessageReceiver calls the handler with an unbuffered message

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 18, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 18, 2020
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2020
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2020
Signed-off-by: Francesco Guardiani <[email protected]>
Signed-off-by: Francesco Guardiani <[email protected]>
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/channel/fanout/fanout_message_handler.go Do not exist 77.1%
pkg/channel/message_receiver.go 67.3% 66.0% -1.2
pkg/channel/multichannelfanout/multi_channel_fanout_message_handler.go Do not exist 90.5%
pkg/channel/swappable/swappable_message_handler.go Do not exist 87.5%

@slinkydeveloper
Copy link
Contributor Author

/retest

@slinkydeveloper
Copy link
Contributor Author

/retest

@n3wscott
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2020
@knative-prow-robot knative-prow-robot merged commit 9bc5e25 into knative:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants